Promtail pull cloudflare logs #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still need to work on fields configuration and some unit testing. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
dannykopping
approved these changes
Nov 24, 2021
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
I'll wait for the go on the documentation before merging. |
jeschkies
reviewed
Nov 24, 2021
dannykopping
approved these changes
Nov 24, 2021
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
KMiller-Grafana
suggested changes
Dec 2, 2021
There was a problem hiding this comment.
Some changes needed. I am not certain that my suggestions for revising the configuration parameter definitions are correct with respect to enumerating values and specifying defaults. I tried to make suggestions that appear more like other places within our Loki configuration documentation.
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
@KMiller-Grafana let me know if we're good to merge. |
jeschkies
approved these changes
Dec 3, 2021
KMiller-Grafana
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR Adds a the ability to pull logs from cloudflare into Promtail.
See the documentation for more information.
Which issue(s) this PR fixes:
Fixes #4725
Special notes for your reviewer:
The cloudflare client was not supporting the log pull API so I'm using a fork for now.
Checklist
CHANGELOG.mdabout the changes.